Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRO-6845] TileGen API #552

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[PRO-6845] TileGen API #552

wants to merge 3 commits into from

Conversation

v-loboda
Copy link
Collaborator

Pull Request description

Changelog

  • Some changes (A description of the changes proposed in the pull request.)

Issues

  • Issue-123 (Link to related issue)

Breaking changes

  • If there are breaking changes, they need to be added to the file Breaking-Changes

Check-list. Чек-лист код-ревью

  • Запрос на слияние в develop.
  • Есть описание к PR.
  • Указаны блокирующие изменения. Breaking-Changes
  • Соответствие кода принятому стилю
    • Описание настроек.
    • Именование настроек.
    • Дефолтные значения.
    • Стиль кода.
  • Работоспособность. Разворачивается на своем окружении из ветки PR.
    • Тест API через тесты helmfile-хуков или коллекций Postman.
  • Не осталось мусора от удаления каких-то параметров. Ищется поиском по проекту из ветки PR.
  • Отработка линтера на чарт из ветки PR. Пример: helm lint charts/search-api

@v-loboda v-loboda requested review from a team as code owners December 16, 2024 11:24
@v-loboda v-loboda force-pushed the PRO-6845-TileGen branch 4 times, most recently from 2de64f7 to 5d6e538 Compare December 17, 2024 06:14
Comment on lines 201 to 209
ingress:
enabled: false
hosts:
- host: tilegen-api.host
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

лучше полное описание

ingress:
  enabled: false
  className: nginx
  hosts:
  - host: tilegen-api.example.com
    paths:
    - path: /
      pathType: Prefix
  tls: []
  # - hosts:
  #   - tilegen-api.example.com
  #   secretName: secret.tls

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

готово

@dbelyaev-nsk
Copy link
Contributor

задача на проверку https://jira.2gis.ru/browse/ONPREM-1351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants